Attention is currently required from: flichtenheld, plaisthos. razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1592?usp=email )
Change subject: configure: Add --enable-code-coverage ...................................................................... Patch Set 4: (4 comments) Patchset: PS4: Is src/compat not instrumented intentionally? I _think_ it would need `AM_CFLAGS = $(CODE_COVERAGE_CFLAGS)` in its Makefile.am as well if we want to cover it. File .gitignore: http://gerrit.openvpn.net/c/openvpn/+/1592/comment/affae7e7_184d6289?usp=email : PS4, Line 4: *.gcno Should we also include `*.gcov`, `*-coverage.info` and `*-coverage/`? File configure.ac: http://gerrit.openvpn.net/c/openvpn/+/1592/comment/902ed96b_05a168d1?usp=email : PS4, Line 1243: [CFLAGS="`echo $CFLAGS | $SED -e 's/-O[s0-9]\\?//g'`"] This actually only matches numerical optimization levels (like `O3`, etc.), but GCC accepts other things, like `-Og` or `-Ofast`, which would mangle `CFLAGS` after this: https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html File src/openvpn/Makefile.am: http://gerrit.openvpn.net/c/openvpn/+/1592/comment/eb78210f_10a68008?usp=email : PS4, Line 38: AM_LIBS = $(CODE_COVERAGE_LIBS) Is `AM_LIBS` a thing? I can't find it in the Automake docs and it doesn't seem to be referenced anywhere in our code. Are you after something like `openvpn_LDADD`? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1592?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I79b2dc4a550b1c5068a45407976b0dfc2f765b33 Gerrit-Change-Number: 1592 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: razvanc <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Mon, 24 Aug 2026 14:38:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
