Attention is currently required from: plaisthos, ralf_lici. ordex has posted comments on this change by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1734?usp=email )
Change subject: Support pre-existing Linux DCO interfaces ...................................................................... Patch Set 1: (1 comment) File src/openvpn/dco_linux.c: http://gerrit.openvpn.net/c/openvpn/+/1734/comment/7e75250d_200e5607?usp=email : PS1, Line 520: int mode_ret = net_iface_ovpn_mode(ctx, dev, &mode); how about moving the (re)definition of `enum ovpn_mode` (and its ifla friends) to networking_sitnl.h and make this new function use it, instead of uint8_t? As discussed on IRC, IFLA attributes are a networking thing, rather than truly DCO specific (although it all overlaps). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1734?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I72302403bddee4b0b0ee2441ae9e246f48d0bc81 Gerrit-Change-Number: 1734 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: ralf_lici <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2026 14:10:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
