Attention is currently required from: plaisthos, ralf_lici.

ordex has posted comments on this change by ralf_lici. ( 
http://gerrit.openvpn.net/c/openvpn/+/1734?usp=email )

Change subject: Support pre-existing Linux DCO interfaces
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/dco_linux.c:

http://gerrit.openvpn.net/c/openvpn/+/1734/comment/68846f49_b680e078?usp=email :
PS1, Line 516:     else if (ret == -EEXIST)
> The else branch is actually needed because ret could also be 0 so this 
> portion of the code has to ex […]
I didn't mean to remove the else branch, but only the keyword "else", because 
the if branch ends with a return.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1734?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I72302403bddee4b0b0ee2441ae9e246f48d0bc81
Gerrit-Change-Number: 1734
Gerrit-PatchSet: 1
Gerrit-Owner: ralf_lici <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: ordex <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: ralf_lici <[email protected]>
Gerrit-Comment-Date: Thu, 03 Sep 2026 15:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <[email protected]>
Comment-In-Reply-To: ralf_lici <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to