Attention is currently required from: flichtenheld, plaisthos. razvanc has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1904?usp=email )
Change subject: buffer: When extracting pointers from buffer, retain const ...................................................................... Patch Set 2: (5 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1904/comment/9badfdf6_6d1189f1?usp=email : PS2, Line 9: Currently you can use BPTR and similar to implictly remove Typo: "implicitly". http://gerrit.openvpn.net/c/openvpn/+/1904/comment/bc2d77d9_4f619c6e?usp=email : PS2, Line 14: pointer if the buffer is not const. Change all call sites "if the buffer is const"? File src/openvpn/buffer.c: http://gerrit.openvpn.net/c/openvpn/+/1904/comment/8f5bf6b8_18e617f5?usp=email : PS2, Line 1138: const uintptr_t u = (uintptr_t)BPTR(buf); CBPTR here as well? File src/openvpn/manage.c: http://gerrit.openvpn.net/c/openvpn/+/1904/comment/a819ef54_4e081b68?usp=email : PS2, Line 2524: sent = man_send_with_fd(man->connection.sd_cli, CBPTR(buf), len, MSG_NOSIGNAL, Not fully sure this is right, `man_send_with_fd()` takes a `void *ptr` here so this will probably trigger a warning on Android builds now. http://gerrit.openvpn.net/c/openvpn/+/1904/comment/922ac025_217c7d89?usp=email : PS2, Line 2531: sent = send(man->connection.sd_cli, CBSTR(buf), len, MSG_NOSIGNAL); Should this be `CBPTR` (not `CBSTR`)? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1904?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib4af7639cdebe81eba05ab04efe6e85e63de0f9e Gerrit-Change-Number: 1904 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Thu, 10 Sep 2026 19:38:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
