Attention is currently required from: plaisthos, razvanc. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1904?usp=email )
Change subject: buffer: When extracting pointers from buffer, retain const ...................................................................... Patch Set 2: (4 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1904/comment/0c344c20_c1663d2b?usp=email : PS2, Line 14: pointer if the buffer is not const. Change all call sites > "if the buffer is const"? I will try to remove a few levels of negation from the sentence ;) File src/openvpn/buffer.c: http://gerrit.openvpn.net/c/openvpn/+/1904/comment/79679f3f_a0e3247c?usp=email : PS2, Line 1138: const uintptr_t u = (uintptr_t)BPTR(buf); > CBPTR here as well? Yeah, code that isn't every compiled, so the build will not flag it. I didn't investigate all existing occurrences of BPTR. File src/openvpn/manage.c: http://gerrit.openvpn.net/c/openvpn/+/1904/comment/3d3c13fd_590c3be8?usp=email : PS2, Line 2524: sent = man_send_with_fd(man->connection.sd_cli, CBPTR(buf), len, MSG_NOSIGNAL, > Not fully sure this is right, `man_send_with_fd()` takes a `void *ptr` here > so this will probably tr […] Yeah, seems we do not run the android build with -Werror: http://buildbot.community.aws.openvpn.in:8010/#/builders/367/builds/3498/steps/7/logs/stdio http://gerrit.openvpn.net/c/openvpn/+/1904/comment/89d8721a_c7b40780?usp=email : PS2, Line 2531: sent = send(man->connection.sd_cli, CBSTR(buf), len, MSG_NOSIGNAL); > Should this be `CBPTR` (not `CBSTR`)? Windows wants a const char*, with CBPTR we get a warning "pointer targets in passing argument 2 of ‘send’ differ in signedness (expected ‘const char *’ but argument is of type ‘const uint8_t *’)" in MinGW build. Using CBSTR let's us avoid using a cast. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1904?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib4af7639cdebe81eba05ab04efe6e85e63de0f9e Gerrit-Change-Number: 1904 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: razvanc <[email protected]> Gerrit-Comment-Date: Fri, 11 Sep 2026 10:40:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: razvanc <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
