Attention is currently required from: plaisthos, syzzer.

MaxF has posted comments on this change by MaxF. ( 
http://gerrit.openvpn.net/c/openvpn/+/1902?usp=email )

Change subject: Check for null-bytes in certificate subjects
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/ssl_verify_openssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1902/comment/3fffd9fc_ccfa4019?usp=email :
PS1, Line 389:                            | ASN1_STRFLGS_ESC_CTRL);
> (Where that last remark about using RFC2253 is about master, not release/2. 
> […]
Alternatively, we could check for "\\0" substrings. Seems cleaner to me than 
parsing the subject twice.

Since you misunderstood the change in master, would you like me to make the 
same change there?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1902?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: release/2.7
Gerrit-Change-Id: Iea1481e94ba1abe18c39d81cd797187c88427571
Gerrit-Change-Number: 1902
Gerrit-PatchSet: 1
Gerrit-Owner: MaxF <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: syzzer <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: syzzer <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Thu, 10 Sep 2026 23:06:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: syzzer <[email protected]>
Comment-In-Reply-To: MaxF <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to