Attention is currently required from: MaxF, plaisthos, syzzer.

cron2 has posted comments on this change by MaxF. ( 
http://gerrit.openvpn.net/c/openvpn/+/1902?usp=email )

Change subject: Check for null-bytes in certificate subjects
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS2:
doing explicit `for()` loops to "find a number in a buffer" feels clumsy... but 
this is just in case you want to do another round anyway, I'll commit it either 
way if Steffan +2's it


File src/openvpn/ssl_verify_openssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1902/comment/2d301fa2_cd509a6b?usp=email :
PS2, Line 408:     }
```
if (memchr(subject_mem->data, 0, subject_mem->length) != NULL)
```
?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1902?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: release/2.7
Gerrit-Change-Id: Iea1481e94ba1abe18c39d81cd797187c88427571
Gerrit-Change-Number: 1902
Gerrit-PatchSet: 2
Gerrit-Owner: MaxF <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: syzzer <[email protected]>
Gerrit-CC: cron2 <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: syzzer <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: MaxF <[email protected]>
Gerrit-Comment-Date: Thu, 17 Sep 2026 09:49:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to