Attention is currently required from: stipa. plaisthos has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1916?usp=email )
Change subject: ssl: do not trust the peer's request to resend the wrapped client key ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/1916/comment/28bbd6d6_fa5ad272?usp=email : PS2, Line 2625: * promising a key we do not have. */ This is quite strangely written and talks about the client itself in a weird 3rd person and does not follow our style of comments ```suggestion * Only accept the EARLY_NEG_FLAG_RESEND_WKC flag * from the server if we are configured with tls-crypt-v2 ``` http://gerrit.openvpn.net/c/openvpn/+/1916/comment/2649fc5a_7c021f6d?usp=email : PS2, Line 2685: && session->tls_wrap.tls_crypt_v2_wkc; I don't particulary like mixing in this condition into this condition as it now does not really match its name anymore. Either rename the function to something better like control_packet_should_append_wkc or move the check if we can actually append the wkc to the caller and keep the function name. Also it seems that we are actually checking for if we can really send it with the " msg(D_TLS_ERRORS, "Could not append tls-crypt-v2 client key");" key that then also properly reports an error in the log instead of silently not sending the WKc key. It feels like this change is better to be just dropped. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1916?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iac6d49d064215510bde9a4cd4600ab3a50a45cb4 Gerrit-Change-Number: 1916 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 09:59:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
