Attention is currently required from: plaisthos. stipa has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1916?usp=email )
Change subject: ssl: do not trust the peer's request to resend the wrapped client key ...................................................................... Patch Set 2: (2 comments) File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/1916/comment/a53010cb_09d451a0?usp=email : PS2, Line 2625: * promising a key we do not have. */ > This is quite strangely written and talks about the client itself in a weird > 3rd person and does not […] Agreed, will simplify the comment. http://gerrit.openvpn.net/c/openvpn/+/1916/comment/b82cac22_b1a27396?usp=email : PS2, Line 2685: && session->tls_wrap.tls_crypt_v2_wkc; > I don't particulary like mixing in this condition into this condition as it > now does not really matc […] Dropped, along with the parameter and the three call sites. Note that tls_wrap_control(), which prints this message, doesn't cover the two call sites in write_outgoing_tls_ciphertext(). They read the key with buf_len() before anything is wrapped, and buf_len() is not NULL-safe. The check in parse_early_negotiation_tlvs() is what keeps those safe, so I kept it. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1916?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iac6d49d064215510bde9a4cd4600ab3a50a45cb4 Gerrit-Change-Number: 1916 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 11:11:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
