Attention is currently required from: plaisthos, ralf_lici. stipa has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1748?usp=email )
Change subject: oob: Measure probe RTT for candidate-band selection ...................................................................... Patch Set 24: (2 comments) File src/openvpn/oob_client.c: http://gerrit.openvpn.net/c/openvpn/+/1748/comment/7c8ef95e_86b86be8?usp=email : PS19, Line 274: results[i].rtt_ms = (ms > 0) ? (unsigned int)ms : 0; > Is it intentional that RTT is always measured from the first probe? > `targets[i]. […] Deliberate: a reply carries nothing that ties it to a send round, so measuring from a resend would make a server that lost the first probe look fast. The comment at the send says so now, and since 1751 the first-send time is kept per address. http://gerrit.openvpn.net/c/openvpn/+/1748/comment/e3b356c4_6521d091?usp=email : PS19, Line 583: openvpn_gettimeofday(&targets[i].sent_at, NULL); > The RTT measurement are confounded by the serialized operations that take > place between the send pha […] The send phase is only sendto() calls — resolution happens before it — so the gap between the first send and the first recvfrom is microseconds per address, not tens of milliseconds; the comment at the receive notes that queue time is included. Kernel receive timestamps (SO_TIMESTAMP) would remove even that, but there is no portable equivalent on Windows, so I left it. The duplicate-endpoint part is fixed: the address is sent once and every entry sharing it gets that one send time. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1748?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I375a41749060b7d006647bc27002c55436c8a8bb Gerrit-Change-Number: 1748 Gerrit-PatchSet: 24 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: ralf_lici <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: ralf_lici <[email protected]> Gerrit-Comment-Date: Thu, 17 Sep 2026 07:59:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ralf_lici <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
