Attention is currently required from: stipa.

plaisthos has posted comments on this change by stipa. ( 
http://gerrit.openvpn.net/c/openvpn/+/1748?usp=email )

Change subject: oob: Measure probe RTT for candidate-band selection
......................................................................


Patch Set 26:

(1 comment)

File src/openvpn/oob_client.c:

http://gerrit.openvpn.net/c/openvpn/+/1748/comment/187af1b5_b3445fac?usp=email :
PS19, Line 274:         results[i].rtt_ms = (ms > 0) ? (unsigned int)ms : 0;
> Deliberate: a reply carries nothing that ties it to a send round, so 
> measuring from a resend would m […]
So that seems like an omission in our spec that we have this problem. We should 
correct this to not having to resort to something like that.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1748?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I375a41749060b7d006647bc27002c55436c8a8bb
Gerrit-Change-Number: 1748
Gerrit-PatchSet: 26
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: ralf_lici <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Thu, 17 Sep 2026 13:18:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ralf_lici <[email protected]>
Comment-In-Reply-To: stipa <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to