Attention is currently required from: flichtenheld, plaisthos, stipa. ralf_lici has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1744?usp=email )
Change subject: oob: Answer SERVER_PROBE on the server (P_CONTROL_OOB_V1) ...................................................................... Patch Set 16: Code-Review-1 (2 comments) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1744/comment/985b183c_a9d3a6ac?usp=email : PS16, Line 138: || verdict == VERDICT_VALID_OOB_V1) By including OOB packets here, `initial_rate_limiter` is charged before `oob_server_probe_check` classifies the payload. Malformed probes and stale probes rejected by `stale_probe_limiter` therefore consume the shared reset-response allowance even though no reply is sent. File src/openvpn/reflect_filter.h: http://gerrit.openvpn.net/c/openvpn/+/1744/comment/c55a7f5b_aca29375?usp=email : PS16, Line 49: bool quiet; `quiet` is not initialized by `initial_rate_limit_init`, which uses `ALLOC_OBJ` rather than zero-initialized allocation. The stale-probe limiter sets it to true, but the normal initial-rate limiter leaves it indeterminate and may therefore randomly suppress warnings. `warning_displayed` is also left uninitialized. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1744?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I930d3789e0313aa0c3bc51ee5fd1d108343d59f0 Gerrit-Change-Number: 1744 Gerrit-PatchSet: 16 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: ralf_lici <[email protected]> Gerrit-CC: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Thu, 17 Sep 2026 13:12:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
