Attention is currently required from: flichtenheld, plaisthos, ralf_lici. stipa has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1744?usp=email )
Change subject: oob: Answer SERVER_PROBE on the server (P_CONTROL_OOB_V1) ...................................................................... Patch Set 17: (2 comments) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1744/comment/4145263e_2e5614fb?usp=email : PS16, Line 138: || verdict == VERDICT_VALID_OOB_V1) > By including OOB packets here, `initial_rate_limiter` is charged before > `oob_server_probe_check` cla […] Right. The shared check is back to reset packets only; the OOB path charges the same limiter right before sending the reply, after the malformed and stale checks. Dropped probes are no longer charged. File src/openvpn/reflect_filter.h: http://gerrit.openvpn.net/c/openvpn/+/1744/comment/ea53f1b8_fc1c2ab3?usp=email : PS16, Line 49: bool quiet; > `quiet` is not initialized by `initial_rate_limit_init`, which uses > `ALLOC_OBJ` rather than zero-ini […] good catch, fixed -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1744?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I930d3789e0313aa0c3bc51ee5fd1d108343d59f0 Gerrit-Change-Number: 1744 Gerrit-PatchSet: 17 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: ralf_lici <[email protected]> Gerrit-CC: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ralf_lici <[email protected]> Gerrit-Comment-Date: Fri, 18 Sep 2026 12:53:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ralf_lici <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
