Attention is currently required from: plaisthos. razvanc has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1919?usp=email )
Change subject: Document notify as auth pending method ...................................................................... Patch Set 1: Code-Review-1 (7 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1919/comment/81df49e6_18e4367e?usp=email : PS1, Line 11: a while to completely and enter the auth pending state. Typo: "to complete" File doc/management-notes.txt: http://gerrit.openvpn.net/c/openvpn/+/1919/comment/7c7971cf_e43f632a?usp=email : PS1, Line 800: happen that is outside the control of the client. This might just a "might just be"? http://gerrit.openvpn.net/c/openvpn/+/1919/comment/b6f1295b_71ad7cef?usp=email : PS1, Line 800: happen that is outside the control of the client. This might just a "some out-of-band authentication happening"? ("is" is present twice). http://gerrit.openvpn.net/c/openvpn/+/1919/comment/413363d8_befd70d3?usp=email : PS1, Line 806: For the user this is Is this text intended or leftover text? http://gerrit.openvpn.net/c/openvpn/+/1919/comment/9e01335e_02ec94d0?usp=email : PS1, Line 809: been defined yet. "So far" implies "yet". http://gerrit.openvpn.net/c/openvpn/+/1919/comment/8bc2e051_2520c182?usp=email : PS1, Line 814: An example message for a message for a server that does some checks against Is "message for a message" correct? http://gerrit.openvpn.net/c/openvpn/+/1919/comment/d34820c0_2999ef0f?usp=email : PS1, Line 822: this message is not negotiated but can just be sent as a gratuitous message. I might be missing something but IIRC the notify pending auth does require action on the client side. Did you mean something else here? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1919?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6217c0541bff81eefa63a987db8904b2feda2546 Gerrit-Change-Number: 1919 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: razvanc <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Thu, 17 Sep 2026 13:43:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
