Attention is currently required from: razvanc. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1919?usp=email )
Change subject: Document notify as auth pending method ...................................................................... Patch Set 1: (7 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1919/comment/d3394571_792b5b52?usp=email : PS1, Line 11: a while to completely and enter the auth pending state. > Typo: "to complete" Acknowledged File doc/management-notes.txt: http://gerrit.openvpn.net/c/openvpn/+/1919/comment/208f625c_e378b19b?usp=email : PS1, Line 800: happen that is outside the control of the client. This might just a > "might just be"? Yeah, this was too strongly worded. http://gerrit.openvpn.net/c/openvpn/+/1919/comment/83cf7934_d63b9aa8?usp=email : PS1, Line 800: happen that is outside the control of the client. This might just a > "some out-of-band authentication happening"? ("is" is present twice). reworded. http://gerrit.openvpn.net/c/openvpn/+/1919/comment/48c30579_d818f90d?usp=email : PS1, Line 806: For the user this is > Is this text intended or leftover text? It certainly does not make sense. Removed it. http://gerrit.openvpn.net/c/openvpn/+/1919/comment/2b1a168c_9ce1134c?usp=email : PS1, Line 809: been defined yet. > "So far" implies "yet". Done http://gerrit.openvpn.net/c/openvpn/+/1919/comment/0d0f82f9_519003ce?usp=email : PS1, Line 814: An example message for a message for a server that does some checks against > Is "message for a message" correct? Yeah that is not a good text, reworded. http://gerrit.openvpn.net/c/openvpn/+/1919/comment/a1db208a_a5e25e27?usp=email : PS1, Line 822: this message is not negotiated but can just be sent as a gratuitous message. > I might be missing something but IIRC the notify pending auth does require > action on the client side […] I tried to clarify. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1919?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6217c0541bff81eefa63a987db8904b2feda2546 Gerrit-Change-Number: 1919 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: razvanc <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: razvanc <[email protected]> Gerrit-Comment-Date: Tue, 22 Sep 2026 13:01:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: razvanc <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
