Attention is currently required from: plaisthos, razvanc. chugly has posted comments on this change by chugly. ( http://gerrit.openvpn.net/c/openvpn/+/1946?usp=email )
Change subject: tests: add a unit test driver for route.c ...................................................................... Patch Set 2: You are right, thanks. The stubs in the driver only match the Linux code path in route.c, so it could never have linked on BSD. Restricted it to Linux in both Makefile.am and CMakeLists.txt, the same way test_networking is. The three helper tests are platform independent and it would be nice to keep them running everywhere. That would mean factoring those helpers out of route.c, along the lines of options_parse.c. Happy to look at that separately if it is wanted. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1946?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9085c55a7efefd31839b00ec8ec9a6f085574dde Gerrit-Change-Number: 1946 Gerrit-PatchSet: 2 Gerrit-Owner: chugly <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: razvanc <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Fri, 25 Sep 2026 02:40:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
