Attention is currently required from: chugly, razvanc.

plaisthos has posted comments on this change by chugly. ( 
http://gerrit.openvpn.net/c/openvpn/+/1946?usp=email )

Change subject: tests: add a unit test driver for route.c
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File CMakeLists.txt:

http://gerrit.openvpn.net/c/openvpn/+/1946/comment/18d068a0_27a7fd53?usp=email :
PS2, Line 912:     if (TARGET test_route)
Instead adding a completely new test driver that only has three tests could you 
just add the new test_route.c to the test_networking target?

test_misc already does this with test_schedule if you need an example.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1946?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9085c55a7efefd31839b00ec8ec9a6f085574dde
Gerrit-Change-Number: 1946
Gerrit-PatchSet: 2
Gerrit-Owner: chugly <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: razvanc <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: chugly <[email protected]>
Gerrit-Attention: razvanc <[email protected]>
Gerrit-Comment-Date: Fri, 25 Sep 2026 09:43:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to