Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1965?usp=email )
Change subject: Add a shared TLV codec and use it for early negotiation ...................................................................... Patch Set 1: Code-Review-1 (3 comments) File src/openvpn/control_msg.c: http://gerrit.openvpn.net/c/openvpn/+/1965/comment/fd568f0b_59ce8397?usp=email : PS1, Line 34: uint16_t field = type & CTRL_MSG_TLV_TYPE_MASK; Is there a valid reason why type might be different from field here? I wonder whether we should ASSERT? http://gerrit.openvpn.net/c/openvpn/+/1965/comment/df6ec7b6_9c4db79c?usp=email : PS1, Line 76: uint8_t *v = buf_read_alloc(buf, hdr->value_len); cppcheck says this should be const File tests/unit_tests/openvpn/test_control_msg.c: http://gerrit.openvpn.net/c/openvpn/+/1965/comment/0ed3b34d_0ab7fd43?usp=email : PS1, Line 107: assert_int_equal(BLEN(&value), 4); Any specific reason why you do not verify the content of the buffer here? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1965?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I89c3133e009dc75dc2c10c607b3f0a24c04e8146 Gerrit-Change-Number: 1965 Gerrit-PatchSet: 1 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 30 Sep 2026 14:35:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
