Attention is currently required from: flichtenheld, plaisthos. Lev Stipakov has posted comments on this change by Lev Stipakov. ( https://gerrit.openvpn.net/c/openvpn/+/1965?usp=email )
Change subject: Add a shared TLV codec and use it for early negotiation ...................................................................... Patch Set 2: (3 comments) File src/openvpn/control_msg.c: https://gerrit.openvpn.net/c/openvpn/+/1965/comment/5bba6d37_4f3a205c?usp=email : PS1, Line 34: uint16_t field = type & CTRL_MSG_TLV_TYPE_MASK; > Is there a valid reason why type might be different from field here? I wonder > whether we should ASSE […] no reason. Will add an assert. https://gerrit.openvpn.net/c/openvpn/+/1965/comment/2e2643a2_eeb32d45?usp=email : PS1, Line 76: uint8_t *v = buf_read_alloc(buf, hdr->value_len); > cppcheck says this should be const added cppcheck to the workflow and added const. File tests/unit_tests/openvpn/test_control_msg.c: https://gerrit.openvpn.net/c/openvpn/+/1965/comment/e258e02e_7d50c895?usp=email : PS1, Line 107: assert_int_equal(BLEN(&value), 4); > Any specific reason why you do not verify the content of the buffer here? Acknowledged -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1965?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I89c3133e009dc75dc2c10c607b3f0a24c04e8146 Gerrit-Change-Number: 1965 Gerrit-PatchSet: 2 Gerrit-Owner: Lev Stipakov <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Thu, 01 Oct 2026 07:36:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
