Attention is currently required from: MaxF. Steffan Karger has posted comments on this change by MaxF. ( https://gerrit.openvpn.net/c/openvpn/+/1985?usp=email )
Change subject: Move check_session_buf_not_used method into the method that free the buffer ...................................................................... Patch Set 1: Code-Review-1 (5 comments) Patchset: PS1: A few whitespace nits and one change that looks accidental to check before merging. Reviewed using git range-diff to check where this differs from the commit in release/2.6 and ran local smoke tests. That all looks good. Would be good if @[email protected] could check this too, since it's originally his patch. File src/openvpn/ssl.c: https://gerrit.openvpn.net/c/openvpn/+/1985/comment/bac2a286_9d1390a6?usp=email : PS1, Line 2276: if (session->opt->pull) Whitespace-only change. Not needed, but doesn't hurt either. https://gerrit.openvpn.net/c/openvpn/+/1985/comment/07f8dfa4_6bbb559d?usp=email : PS1, Line 2453: || multi->multi_state == CAS_SUCCEEDED)) Another whitespace-only change. https://gerrit.openvpn.net/c/openvpn/+/1985/comment/56f38879_ef0dee78?usp=email : PS1, Line 3106: "still in use (tls_wrap.work.data)"); Whitespace-only https://gerrit.openvpn.net/c/openvpn/+/1985/comment/10450665_3180dcea?usp=email : PS1, Line 3250: "session promoted to %strusted", This changes the log message and logic around it. Is that needed or useful? Or just accidental result of resolving a merge conflict? -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: release/2.5 Gerrit-Change-Id: I64920ed9f714803604d76c6df6b38cf20ce7626d Gerrit-Change-Number: 1985 Gerrit-PatchSet: 1 Gerrit-Owner: MaxF <[email protected]> Gerrit-Reviewer: Steffan Karger <[email protected]> Gerrit-CC: Arne Schwabe <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: MaxF <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2026 19:27:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
