Attention is currently required from: Steffan Karger. Max Fillinger has posted comments on this change by Max Fillinger. ( https://gerrit.openvpn.net/c/openvpn/+/1985?usp=email )
Change subject: Move check_session_buf_not_used method into the method that free the buffer ...................................................................... Patch Set 1: (4 comments) File src/openvpn/ssl.c: https://gerrit.openvpn.net/c/openvpn/+/1985/comment/6c2ee96f_dfd03e49?usp=email : PS1, Line 2276: if (session->opt->pull) > Whitespace-only change. Not needed, but doesn't hurt either. The uncrustify hook wouldn't let me commit it without this change. https://gerrit.openvpn.net/c/openvpn/+/1985/comment/9afd2831_7b00a2d6?usp=email : PS1, Line 2453: || multi->multi_state == CAS_SUCCEEDED)) > Another whitespace-only change. Uncrustify, again. https://gerrit.openvpn.net/c/openvpn/+/1985/comment/af10120b_b214ca1d?usp=email : PS1, Line 3106: "still in use (tls_wrap.work.data)"); > Whitespace-only Uncrustify, again. https://gerrit.openvpn.net/c/openvpn/+/1985/comment/854a9a57_0d293370?usp=email : PS1, Line 3250: "session promoted to %strusted", > This changes the log message and logic around it. […] Accidental, I reverted to the old log message. While doing so, uncrustify found something else unrelated to complain about for some reason. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: release/2.5 Gerrit-Change-Id: I64920ed9f714803604d76c6df6b38cf20ce7626d Gerrit-Change-Number: 1985 Gerrit-PatchSet: 1 Gerrit-Owner: Max Fillinger <[email protected]> Gerrit-Reviewer: Steffan Karger <[email protected]> Gerrit-CC: Arne Schwabe <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Steffan Karger <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2026 21:53:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Steffan Karger <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
