Attention is currently required from: Arne Schwabe, Frank Lichtenheld.

Răzvan Cojocaru has posted comments on this change by Frank Lichtenheld. ( 
https://gerrit.openvpn.net/c/openvpn/+/1987?usp=email )

Change subject: buffer: Clean up rm_trailing_chars
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
Actually on a second look, `chomp()` appears to be the only caller of 
`rm_trailing_chars()`.

Is in this case `rm_trailing_chars()` worth keeping at all?



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/1987?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I47e0741c75832a8f3fe161769feb27ddbfba3cdd
Gerrit-Change-Number: 1987
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Lichtenheld <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Răzvan Cojocaru <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Attention: Frank Lichtenheld <[email protected]>
Gerrit-Comment-Date: Thu, 08 Oct 2026 15:00:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to