Attention is currently required from: Arne Schwabe, Răzvan Cojocaru. Frank Lichtenheld has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/1987?usp=email )
Change subject: buffer: Clean up rm_trailing_chars ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: > Actually on a second look, `chomp()` appears to be the only caller of > `rm_trailing_chars()`. […] I would leave it. I think with how it uses strchr it is a natural generalization. But don't have a strong opinion. File src/openvpn/buffer.c: https://gerrit.openvpn.net/c/openvpn/+/1987/comment/e9267163_9a6ce16e?usp=email : PS1, Line 606: } > This can be compacted further to: […] Done -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I47e0741c75832a8f3fe161769feb27ddbfba3cdd Gerrit-Change-Number: 1987 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Thu, 08 Oct 2026 16:02:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Răzvan Cojocaru <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
