Attention is currently required from: Arne Schwabe, Răzvan Cojocaru. Frank Lichtenheld has posted comments on this change by Arne Schwabe. ( https://gerrit.openvpn.net/c/openvpn/+/1858?usp=email )
Change subject: Implement sending/receiving app custom control protocol messages ...................................................................... Patch Set 11: Code-Review-1 (10 comments) Patchset: PS11: Didn't get through it fully, yet. But noted some nitpicks File CMakeLists.txt: https://gerrit.openvpn.net/c/openvpn/+/1858/comment/6e7bad6f_d9b4668d?usp=email : PS11, Line 576: src/openvpn/pushlist.h Weird whitespace? File doc/man-sections/client-options.rst: https://gerrit.openvpn.net/c/openvpn/+/1858/comment/370e5fb1_06efc579?usp=email : PS11, Line 23: See management-notes.txt in the OpenVPN distribution and the OpenVPN RFC double space before "and" File src/openvpn/options.c: https://gerrit.openvpn.net/c/openvpn/+/1858/comment/8ad491b8_00cb2562?usp=email : PS11, Line 7137: else if (streq(p[0], "app-custom-control") && p[1] && !p[2]) Add to usage? File src/openvpn/push.c: https://gerrit.openvpn.net/c/openvpn/+/1858/comment/bbbd2c0f_63345053?usp=email : PS11, Line 267: parse_server_pushed_info_acc(c, &m); why use the string instead of the buffer here? File src/openvpn/push_util.c: https://gerrit.openvpn.net/c/openvpn/+/1858/comment/1f759213_e4501889?usp=email : PS11, Line 371: #endif /* ifdef ENABLE_MANAGEMENT */ Superfluous change File tests/unit_tests/openvpn/Makefile.am: https://gerrit.openvpn.net/c/openvpn/+/1858/comment/98eafe14_3b65f58e?usp=email : PS11, Line 106: test_acc.c test_acc.h \ whitespace File tests/unit_tests/openvpn/mock_management.h: https://gerrit.openvpn.net/c/openvpn/+/1858/comment/7db95ab2_14dd2db2?usp=email : PS11, Line 23: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. old header File tests/unit_tests/openvpn/mock_management.c: https://gerrit.openvpn.net/c/openvpn/+/1858/comment/d98eb7b8_09a3846e?usp=email : PS11, Line 64: } Superfluous change File tests/unit_tests/openvpn/test_acc.h: https://gerrit.openvpn.net/c/openvpn/+/1858/comment/416878a1_7c543c75?usp=email : PS11, Line 23: * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. old header -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1858?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4a6a6ef41e15896b8b79d795b2a6de86b8ae4c84 Gerrit-Change-Number: 1858 Gerrit-PatchSet: 11 Gerrit-Owner: Arne Schwabe <[email protected]> Gerrit-Reviewer: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Thu, 15 Oct 2026 11:00:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
