Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/1999?usp=email
to review the following change.
Change subject: clang-format: Enable InsertNewlineAtEOF
......................................................................
clang-format: Enable InsertNewlineAtEOF
We had some patches recently that committed files
without newline at EOF. Enforce consistency.
Change-Id: I6294665e39ddf012f0a3943d0e356576f4fe02e1
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M .clang-format
M src/compat/compat-strtok_r.c
M src/openvpn/schedule.c
M src/openvpn/siphash.c
M tests/unit_tests/openvpn/siphash_openssl.h
M tests/unit_tests/openvpn/test_schedule.h
6 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/99/1999/1
diff --git a/.clang-format b/.clang-format
index 0823739..23d224b 100644
--- a/.clang-format
+++ b/.clang-format
@@ -32,6 +32,7 @@
IndentWidth: '4'
IndentWrappedFunctionNames: false
InsertBraces: true
+InsertNewlineAtEOF: true
KeepEmptyLines:
AtEndOfFile: false
AtStartOfBlock: false
diff --git a/src/compat/compat-strtok_r.c b/src/compat/compat-strtok_r.c
index debcdd3..4240458 100644
--- a/src/compat/compat-strtok_r.c
+++ b/src/compat/compat-strtok_r.c
@@ -98,4 +98,4 @@
}
/* NOTREACHED */
}
-#endif
\ No newline at end of file
+#endif
diff --git a/src/openvpn/schedule.c b/src/openvpn/schedule.c
index 6c60dc2..ff243dc 100644
--- a/src/openvpn/schedule.c
+++ b/src/openvpn/schedule.c
@@ -389,4 +389,4 @@
{
s->earliest_wakeup = NULL; /* invalidate cache */
schedule_remove_node(s, e);
-}
\ No newline at end of file
+}
diff --git a/src/openvpn/siphash.c b/src/openvpn/siphash.c
index e31b708..b9fc5e3 100644
--- a/src/openvpn/siphash.c
+++ b/src/openvpn/siphash.c
@@ -46,4 +46,4 @@
} ret;
siphash(k, length, hash_key, ret.out, sizeof(ret.out));
return ret.hash;
-}
\ No newline at end of file
+}
diff --git a/tests/unit_tests/openvpn/siphash_openssl.h
b/tests/unit_tests/openvpn/siphash_openssl.h
index 0f1d329..49c6a9d 100644
--- a/tests/unit_tests/openvpn/siphash_openssl.h
+++ b/tests/unit_tests/openvpn/siphash_openssl.h
@@ -61,4 +61,4 @@
*/
bool
siphash_openssl_available(void *sip_context);
-#endif /* ifndef SIPHASH_OPENSSL_H */
\ No newline at end of file
+#endif /* ifndef SIPHASH_OPENSSL_H */
diff --git a/tests/unit_tests/openvpn/test_schedule.h
b/tests/unit_tests/openvpn/test_schedule.h
index 55dc591..3705af9 100644
--- a/tests/unit_tests/openvpn/test_schedule.h
+++ b/tests/unit_tests/openvpn/test_schedule.h
@@ -24,4 +24,4 @@
/** Runs the schedule test */
void
schedule_test(void **state);
-#endif
\ No newline at end of file
+#endif
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/1999?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6294665e39ddf012f0a3943d0e356576f4fe02e1
Gerrit-Change-Number: 1999
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Lichtenheld <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
