Attention is currently required from: Arne Schwabe, Heiko Hund. Frank Lichtenheld has posted comments on this change by Heiko Hund. ( https://gerrit.openvpn.net/c/openvpn/+/2001?usp=email )
Change subject: openvpnserv: add automatic service again ...................................................................... Patch Set 2: (5 comments) Patchset: PS2: Added some nitpicks File src/openvpnserv/automatic.c: https://gerrit.openvpn.net/c/openvpn/+/2001/comment/13e5f53f_d35ee7d9?usp=email : PS2, Line 24: * The automatic service starts one OpenVPN process for each configuration Could be marked as a `@file` doxygen comment? https://gerrit.openvpn.net/c/openvpn/+/2001/comment/6b9d3700_ad7675e1?usp=email : PS2, Line 39: /* Time we give the interactive service to accept our connection */ Make these doxygen comments as well? https://gerrit.openvpn.net/c/openvpn/+/2001/comment/7c72c43b_e94e6652?usp=email : PS2, Line 107: * @param pos in/out position in the buffer in wide characters - use `[in,out]` instead of staging in/out in the text - maybe mention that pos points to after the `\0`? File tests/unit_tests/openvpnserv/test_openvpnserv_automatic.c: https://gerrit.openvpn.net/c/openvpn/+/2001/comment/6276d1a4_9216ce73?usp=email : PS2, Line 215: name[i] = L'a'; Why are you not using wmemset here? -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I089e5b79600c535e3c0c5d1bb14319ac03f4144b Gerrit-Change-Number: 2001 Gerrit-PatchSet: 2 Gerrit-Owner: Heiko Hund <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-CC: Frank Lichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Heiko Hund <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Fri, 16 Oct 2026 07:46:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
