Attention is currently required from: Arne Schwabe, Frank Lichtenheld. Heiko Hund has posted comments on this change by Heiko Hund. ( https://gerrit.openvpn.net/c/openvpn/+/2001?usp=email )
Change subject: openvpnserv: add automatic service again ...................................................................... Patch Set 2: (4 comments) File src/openvpnserv/automatic.c: https://gerrit.openvpn.net/c/openvpn/+/2001/comment/e20872ad_42be61e2?usp=email : PS2, Line 24: * The automatic service starts one OpenVPN process for each configuration > Could be marked as a `@file` doxygen comment? Done https://gerrit.openvpn.net/c/openvpn/+/2001/comment/e5bf5628_e5773663?usp=email : PS2, Line 39: /* Time we give the interactive service to accept our connection */ > Make these doxygen comments as well? Done https://gerrit.openvpn.net/c/openvpn/+/2001/comment/ee2b70d1_628230b1?usp=email : PS2, Line 107: * @param pos in/out position in the buffer in wide characters > - use `[in,out]` instead of staging in/out in the text […] Done File tests/unit_tests/openvpnserv/test_openvpnserv_automatic.c: https://gerrit.openvpn.net/c/openvpn/+/2001/comment/146ddf2b_3285495b?usp=email : PS2, Line 215: name[i] = L'a'; > Why are you not using wmemset here? Done -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I089e5b79600c535e3c0c5d1bb14319ac03f4144b Gerrit-Change-Number: 2001 Gerrit-PatchSet: 2 Gerrit-Owner: Heiko Hund <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-CC: Frank Lichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Sat, 17 Oct 2026 08:46:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frank Lichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
