Attention is currently required from: Arne Schwabe, Răzvan Cojocaru. Frank Lichtenheld has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/2157?usp=email )
Change subject: Various trivial -Wsign-conversion fixes ...................................................................... Patch Set 2: (2 comments) File src/openvpn/crypto.c: https://gerrit.openvpn.net/c/openvpn/+/2157/comment/84391446_ecd986b1?usp=email : PS2, Line 858: + max_uint(OPENVPN_MAX_HMAC_SIZE, OPENVPN_AEAD_TAG_LENGTH); > `packet_id_size(true)` returns `int`, so the sum still converts `int` to > `unsigned int`. That part is in the next patch. The distribution into patches is sometimes a bit awkward, admittedly. https://gerrit.openvpn.net/c/openvpn/+/2157/comment/c1ef59ef_c4b97d88?usp=email : PS2, Line 1553: fmt = format_hex_ex((const uint8_t *)&key, sizeof(key), 0, bytes_per_line, "\n", &gc); > `crypto. […] Done -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I02f8df01f8f33cb9cd04cd844d1f1893688f51e8 Gerrit-Change-Number: 2157 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Tue, 10 Nov 2026 12:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Răzvan Cojocaru <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
