Attention is currently required from: Arne Schwabe, Frank Lichtenheld. Răzvan Cojocaru has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/2157?usp=email )
Change subject: Various trivial -Wsign-conversion fixes ...................................................................... Patch Set 3: Code-Review-1 (3 comments) File tests/unit_tests/openvpn/test_crypto.c: https://gerrit.openvpn.net/c/openvpn/+/2157/comment/6ea1b23f_be593c60?usp=email : PS3, Line 528: ovpn_hkdf_expand(prk, info, sizeof(info), out, L); `test_crypto.c:528:52: error: conversion to 'size_t' from 'int' may change the sign of the result [-Werror=sign-conversion]` https://gerrit.openvpn.net/c/openvpn/+/2157/comment/3c5b44a7_a19e88d3?usp=email : PS3, Line 530: assert_memory_equal(out, okm, L); `test_crypto.c:530:35: error: conversion to 'size_t' from 'int' may change the sign of the result [-Werror=sign-conversion]` File tests/unit_tests/openvpn/test_networking.c: https://gerrit.openvpn.net/c/openvpn/+/2157/comment/3d3f1394_d5ed73d0?usp=email : PS3, Line 46: printf("CMD: ip link set %s mtu %d\n", iface, mtu); `%u` now? -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I02f8df01f8f33cb9cd04cd844d1f1893688f51e8 Gerrit-Change-Number: 2157 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 10 Nov 2026 12:43:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
