Attention is currently required from: Arne Schwabe, Răzvan Cojocaru. Antonio Quartulli has posted comments on this change by Răzvan Cojocaru. ( https://gerrit.openvpn.net/c/openvpn/+/2162?usp=email )
Change subject: openvpnserv: keep IPv6 name servers in NRPT exclude rules ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: As far as I understand, this patch fixes also a separate bug: both readers now set addrs[0] = '\0' first. RegGetValueA() leaves the buffer untouched when the value doesn't exist. And since a slot is reused after an interface is skipped, a later interface with no name servers could inherit the previous interface's addresses. Maybe you didn't realize :-D but could you double check my finding and mention it in the commit too? For the rest, the patch looks good to me. Only detail is that I couldn't test/build on windows.. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2162?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic602b125d857f1beed4af8661f522d339bc9e972 Gerrit-Change-Number: 2162 Gerrit-PatchSet: 1 Gerrit-Owner: Răzvan Cojocaru <[email protected]> Gerrit-Reviewer: Antonio Quartulli <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Wed, 11 Nov 2026 09:00:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
