Attention is currently required from: Arne Schwabe, Răzvan Cojocaru. Heiko Hund has posted comments on this change by Răzvan Cojocaru. ( https://gerrit.openvpn.net/c/openvpn/+/2162?usp=email )
Change subject: openvpnserv: keep IPv6 name servers in NRPT exclude rules ...................................................................... Patch Set 3: (2 comments) File src/openvpnserv/interactive.c: https://gerrit.openvpn.net/c/openvpn/+/2162/comment/d99e56a4_a98881a0?usp=email : PS3, Line 2138: TrimNameServers(PSTR addrs) First I was like, meh. Windows handles this, but turns out not for each of the ways you can set name servers with system tools. So, this actually does make sense to do. WMI inputs are not sanitized, and ppl will set bad data with powershell sooner or later. https://gerrit.openvpn.net/c/openvpn/+/2162/comment/de1ade99_cb43a208?usp=email : PS3, Line 2589: v6_addrs[-1] = ','; While technically correct, I think `data[i].addresses[v4_addrs_size - 1] = ',';` is understandable easier -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2162?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic602b125d857f1beed4af8661f522d339bc9e972 Gerrit-Change-Number: 2162 Gerrit-PatchSet: 3 Gerrit-Owner: Răzvan Cojocaru <[email protected]> Gerrit-Reviewer: Antonio Quartulli <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-CC: Heiko Hund <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Thu, 12 Nov 2026 17:28:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
