Attention is currently required from: Arne Schwabe, Frank Lichtenheld. Răzvan Cojocaru has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/2177?usp=email )
Change subject: networking_sitnl: Reduce boilerplate code for parameter checks ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/openvpn/networking_sitnl.c: https://gerrit.openvpn.net/c/openvpn/+/2177/comment/ae39d9af_0aa207c2?usp=email : PS1, Line 720: } This function duplicates a lot of `get_ifindex()`, and looking at callers we might even get away with a single one of the above functions. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2177?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6f5ca53d4288b0921610f7a3f84ad55d2ab49118 Gerrit-Change-Number: 2177 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 11 Nov 2026 18:23:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
