Attention is currently required from: Arne Schwabe, Răzvan Cojocaru.

Frank Lichtenheld has posted comments on this change by Frank Lichtenheld. ( 
https://gerrit.openvpn.net/c/openvpn/+/2177?usp=email )

Change subject: networking_sitnl: Reduce boilerplate code for parameter checks
......................................................................


Patch Set 2:

(1 comment)

File src/openvpn/networking_sitnl.c:

https://gerrit.openvpn.net/c/openvpn/+/2177/comment/45efe0ca_bdda7b8a?usp=email 
:
PS1, Line 720: }
> This function duplicates a lot of `get_ifindex()`, and looking at callers we 
> might even get away wit […]
Done



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2177?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6f5ca53d4288b0921610f7a3f84ad55d2ab49118
Gerrit-Change-Number: 2177
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Lichtenheld <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Răzvan Cojocaru <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Răzvan Cojocaru <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Comment-Date: Thu, 12 Nov 2026 17:12:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Răzvan Cojocaru <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to