Attention is currently required from: Arne Schwabe, Frank Lichtenheld. Răzvan Cojocaru has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/1186?usp=email )
Change subject: Enable -Wsign-conversion ...................................................................... Patch Set 19: Code-Review-1 (4 comments) File src/openvpn/buffer.c: https://gerrit.openvpn.net/c/openvpn/+/1186/comment/4d642f67_cdedf54d?usp=email : PS19, Line 741: #endif Is this ever popped? If it is, I can't find it. File src/openvpn/options.c: https://gerrit.openvpn.net/c/openvpn/+/1186/comment/90b13b63_fd870ee0?usp=email : PS19, Line 7981: #pragma GCC diagnostic pop This covers almost all of the file. Also, at first sight I thought it's copy/paste mistake. 🙂 File src/openvpn/ssl_verify.c: https://gerrit.openvpn.net/c/openvpn/+/1186/comment/78bbe36f_b85c843f?usp=email : PS19, Line 899: #endif This doesn't appear to be popped anywhere. File src/openvpn/tun.c: https://gerrit.openvpn.net/c/openvpn/+/1186/comment/8958078c_c5c74c22?usp=email : PS19, Line 2294: #endif This doesn't seem to have a corresponding pop. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iecf502ec811e99c56647b2d45298fa0fb66960fb Gerrit-Change-Number: 1186 Gerrit-PatchSet: 19 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Thu, 12 Nov 2026 15:20:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
