Attention is currently required from: Arne Schwabe, Răzvan Cojocaru. Frank Lichtenheld has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/1186?usp=email )
Change subject: Enable -Wsign-conversion ...................................................................... Patch Set 20: (3 comments) File src/openvpn/buffer.c: https://gerrit.openvpn.net/c/openvpn/+/1186/comment/109b7718_771bb541?usp=email : PS19, Line 741: #endif > Is this ever popped? If it is, I can't find it. Done File src/openvpn/ssl_verify.c: https://gerrit.openvpn.net/c/openvpn/+/1186/comment/321efdb3_e0b6dcd0?usp=email : PS19, Line 899: #endif > This doesn't appear to be popped anywhere. Done File src/openvpn/tun.c: https://gerrit.openvpn.net/c/openvpn/+/1186/comment/cd6ac4da_bde03fed?usp=email : PS19, Line 2294: #endif > This doesn't seem to have a corresponding pop. Done -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iecf502ec811e99c56647b2d45298fa0fb66960fb Gerrit-Change-Number: 1186 Gerrit-PatchSet: 20 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Thu, 12 Nov 2026 17:12:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Răzvan Cojocaru <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
