Attention is currently required from: Arne Schwabe.

Hello Arne Schwabe,

I'd like you to do a code review.
Please visit

    https://gerrit.openvpn.net/c/openvpn/+/2216?usp=email

to review the following change.


Change subject: ssl_openssl: don't log inline CRL contents
......................................................................

ssl_openssl: don't log inline CRL contents

With an inline <crl-verify>, crl_file holds the PEM data, and the
"CRL: loaded" message printed all of it. Use print_key_filename() as
the other CRL messages do.

Change-Id: Ie5336121e8a48e5a63b509d6a30349be42d311f9
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpn/ssl_openssl.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/16/2216/1

diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c
index b95de8e..7fdb3c5 100644
--- a/src/openvpn/ssl_openssl.c
+++ b/src/openvpn/ssl_openssl.c
@@ -1415,7 +1415,8 @@
         }
         num_crls_loaded++;
     }
-    msg(M_INFO, "CRL: loaded %d CRLs from file %s", num_crls_loaded, crl_file);
+    msg(M_INFO, "CRL: loaded %d CRLs from file %s", num_crls_loaded,
+        print_key_filename(crl_file, crl_inline));
     ssl_ctx->crls = crls;
     BIO_free(in);
 }

--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2216?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie5336121e8a48e5a63b509d6a30349be42d311f9
Gerrit-Change-Number: 2216
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
  • [Openvpn-devel] [XS] Cha... Code Review

Reply via email to