On Jan 30, 2009, at 1:33 PM, Gurkan Erdogdu wrote:
Please verify that this release package is correct and vote for the
motion to publish this as a openwebbeans M1 release. All votes are
welcome and
will be counted.
This is my +1
-1
Running RAT shows the following files don't have Apache src license
headers. Not all of these files need a header (e.g. the licences/*
files), but looks like many of them do... Certainly all of the *.java
and *.xml files.
!????? ./distribution/src/assembly/dist-all.xml
!????? ./distribution/src/assembly/dist-binary.xml
!????? ./distribution/src/assembly/dist-sources.xml
!????? ./licences/MPL-1.1.txt
!????? ./licences/cddl-1.0.txt
!????? ./licences/cpl-1.0.txt
!????? ./licences/dom4j-licence.txt
!????? ./licences/hsqldb_lic.txt
!????? ./licences/hypersonic_lic.txt
!????? ./samples/pom.xml
!????? ./samples/guess/pom.xml
!????? ./samples/guess/src/main/resources/log4j.properties
!????? ./samples/guess/src/main/webapp/home.xhtml
!????? ./samples/guess/src/main/webapp/index.html
!????? ./samples/guess/src/main/webapp/login.xhtml
!????? ./samples/guess/src/main/webapp/META-INF/MANIFEST.MF
!????? ./samples/guess/src/site/apt/index.apt
!????? ./samples/src/site/apt/index.apt
!????? ./src/site/apt/contributing.apt
!????? ./src/site/apt/index.apt
!????? ./src/site/apt/irc.apt
!????? ./src/site/apt/jsr299.apt
!????? ./src/site/apt/examples/guess.apt
!????? ./src/site/apt/extensions/index.apt
!????? ./src/site/fml/faq.fml
!????? ./webbeans-api/src/main/java/META-INF/MANIFEST.MF
!????? ./webbeans-api/src/main/java/javax/event/Observer.java
!????? ./webbeans-api/src/site/apt/index.apt
!????? ./webbeans-impl/src/main/java/log4j.properties
!????? ./webbeans-impl/src/main/java/META-INF/MANIFEST.MF
!????? ./webbeans-impl/src/main/java/META-INF/faces-config.xml
!????? ./webbeans-impl/src/site/apt/index.apt
!????? ./webbeans-impl/src/test/java/org/apache/webbeans/test/mock/
MockServletContext.java
!????? ./webbeans-impl/src/test/java/org/apache/webbeans/test/
unittests/config/ScannerTestBean.java
!????? ./webbeans-impl/src/test/java/org/apache/webbeans/test/
unittests/config/WebBeansScannerTest.java
!????? ./webbeans-tck/src/test/java/org/apache/webbeans/test/tck/
BeansImpl.java
!????? ./webbeans-tck/src/test/java/org/apache/webbeans/test/tck/
ContainersImpl.java
!????? ./webbeans-tck/src/test/java/org/apache/webbeans/test/tck/
ContextsImpl.java
!????? ./webbeans-tck/src/test/java/org/apache/webbeans/test/tck/
ManagersImpl.java
!????? ./webbeans-tck/src/test/resources/log4j.properties
!????? ./webbeans-tck/src/test/resources/META-INF/web-beans-
tck.properties
The license/notice files in http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M1/plugins/org/apache/openwebbeans/guess/1.0.0-incubating-M1/guess-1.0.0-incubating-M1.war
is almost certainly incorrect. I didn't see any obvious problems in
any other jars.
Less serious, but should be fixed: the build instructions in
README.txt are incorrect.
--kevan
