>>>Id favour a webbeans-jsf2, I think that's more future proof. I think that there is no need to define extra jsf module/project. There is no such a thing that "You could use it in JSF 1.2 but not JSF2 or vice versa". We support JSF2 and JSF2 is backward compatible. But, if we really emphasize that the code is related with "JSF2", we can create a package with named "jsf2" in webbeans-jsf project.
Thanks; --Gurkan 2009/12/17 Mark Struberg <[email protected]> > cool! > > Id favour a webbeans-jsf2, I think that's more future proof. > > And as Gurkan already said: please attach the patch as owb-171-patch.rfc in > Jira. > > txs and LieGrue, > strub > > --- Sven Linstaedt <[email protected]> schrieb am Do, > 17.12.2009: > > > Von: Sven Linstaedt <[email protected]> > > Betreff: Integration of JSF2 specific API calls > > An: [email protected] > > Datum: Donnerstag, 17. Dezember 2009, 2:24 > > Back in business. > > > > I am currently working on a patch for OWB-171. Besides some > > cleanups I have refactored the code: > > > > Conversation is request scoped and solely created or > > restored by ConversationBean which delegates the later one > > to the ConversationManager. WebBeansPhaseListener is only > > responsible for retrieving and handling the > > ConversationContext. Conversation is only restored using the > > "cid" request parameter and not the > > UIViewRoot's attributes, because the view is only > > accessible after restore view phase. The restored > > conversation (and it's context of course) must actually > > exist for restoring the view. This chicken or egg problem > > was the reason not to store the the cid in the view's > > attributes, because restoring these attributes actually > > needs restoring the conversation beforehand. > > > > > > There is still an issue with the jsf2-example: In case of > > ajax requests which start a long running conversation, all > > form's action attributes needs to be updated to reflect > > the current active conversation for following request. This > > could be done using JSF2 specific API features. At the > > moment webbeans-impl is purely compiled against the JSF 1.2 > > API. Without the necessary abstraction there is no chance to > > get the JSF2 specific ajax functionality working again. > > > > > > I have attached the patch to this mail and not to the > > issue, because the patch is not meant for inclusion yet, but > > for testing purposes. Integration it and rerunning the > > jsf2-example points out my problem. If you disable ajax by > > disabling javascript in your browser e.g. the conversation > > example is working, because in this case the full page with > > updated form's action urls is rendered during each > > action invocation. > > > > > > Last but not least: Do you guys have a glue how JSF2 > > specific extension for conversation handling should be > > integrated? I supose either adding another project > > (webbeans-jsf2 e.g.) or updating the JSF API (not impl) > > version to 2.x and making sure, we are loading JSF2 specific > > classes only for this ajax purpose. > > > > > > good night, Sven > > > > > > __________________________________________________ > Do You Yahoo!? > Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz > gegen Massenmails. > http://mail.yahoo.com > -- Gurkan Erdogdu http://gurkanerdogdu.blogspot.com
