Hi John, This looks great! thank you. I've been playing with it a little bit and found an interesting behavior, adding this:
http://gist.github.com/30350 in test/ft_93_on_error.rb yields: ================================================ 1) Failure: test_4(FlowTest93) [./test/flowtestbase.rb:289:in `dotest' ./test/ft_93_on_error.rb:171:in `test_4']: flow failed : traced : '0 1 rescue' but was expecting : '0 1 rescue 2 parent_rescue' . <false> is not true. ================================================ It seems that the parent 'on_error' handler doesn't get called if a child 'on_error' handler raises an exception, the sequence is simply cancelled. I'm off to update my flows with this new mechanism... Happy thanksgiving to you too (is there Thanksgiving in Japan?) -- Raphael. On Nov 27, 4:14 pm, "John Mettraux" <[EMAIL PROTECTED]> wrote: > On Thu, Nov 27, 2008 at 10:40 AM, John Mettraux <[EMAIL PROTECTED]> wrote: > > On Thu, Nov 27, 2008 at 10:18 AM, Raphael Simon <[EMAIL PROTECTED]> wrote: > >> That's great! I would be happy to do some testing or contribute in other > >> ways, let me know. > > Hi Raphael, > > the feature branch is almost done, here are the current tests for the > 'on_error' : > > http://github.com/jmettraux/ruote/tree/raphael_error_handling/test/ft... > > I have 3 cases for now > > ** on_error = 'fail_path' > > removes the block containing the error and executes the subprocess > named 'fail_path' (note that a lonely participant name is valid here) > > ** on_error = '' > > the blank error handler indicates that errors within this block should > be handled the regular way (no error handling, pass to error journal). > Could be useful for disabled error handling in a sub block > > ** on_error = 'undo' > > the block is simply cancelled and the process resumes right after it > (equivalent to the 'undo' expression) > > I will certainly implement 'redo' as well, might come in handy. Once > the feature looks OK, I'll merge in the master branch. > > What do you think ? (what do others think btw ?) > > Happy Thanksgiving ! > > -- > John Mettraux - http://jmettraux.wordpress.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruote (OpenWFEru) users" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/openwferu-users?hl=en -~----------~----~----~----~------~----~------~--~---
