On Sun, May 24, 2009 at 5:29 AM, John Mettraux <[email protected]>wrote:
> > Hi Kenneth, > > I just pulled your work and try to run it (ruote$ ruby test/test.rb), > it gives me three errors : > > http://gist.github.com/116942 > > Have to head out now, sorry, not much time to investigate... Actually grateful you didn't have time to clean up my mess :) Here is the final result: OpenWFE::Json will, in order, try to use ActiveSupport then the JSON gem. This is needed since there are some very bad side effects if your require the JSON gem and ActiveSupport in the same process, at least with ActiveSupport leading up to the commit I initially referenced in the first mail. Once ActiveSupport is used as a backend, it cannot be changed to JSON. Once ActiveSupport is loaded however, it does patch the standard Logger class, and that broke the logging test. I cleaned up the test (removed the check for ActiveRecord) and updated the logging module to make sure that $OWFE_LOG's formatter is always set to the expected one. This isn't very clean, but it works. I've also updated all my participants to now use the new JSON backend, making them less strict and backing off from my first bullish attempt at locking ruote down to ActiveSupport. I did as best I could to make sure everything works with ActiveSupport not being available. In final, I nuked any direct references I could find to either JSON or ActiveSupport::JSON method calls, except for the utility class and the files in old_test/. Hope this sorts it out properly and gives us all some space to breathe. Best -- Kenneth Kalmer [email protected] http://opensourcery.co.za @kennethkalmer --~--~---------~--~----~------------~-------~--~----~ you received this message because you are subscribed to the "ruote users" group. to post : send email to [email protected] to unsubscribe : send email to [email protected] more options : http://groups.google.com/group/openwferu-users?hl=en -~----------~----~----~----~------~----~------~--~---
