On Sun, Jan 3, 2010 at 6:06 AM, Matthew Nichols wrote:
>
> We're excited to try out Ruote 2.1. After giving it a whirl, we noticed a
> couple of issues...
> Issue 1:
> We don't use 'yajl'. It looks like doing a rescue on the same line as a
> require that may fail does not catch the error. I tried it in 1.8.7 and
> 1.9.1
> This doesn't work if the gem is not installed:
> require 'yajl' rescue LoadError require 'json'
>
> This works:
> begin
>   require 'yajl'
> rescue LoadError
>   require 'json'
> end
>
> Not really sure why the first one doesn't work. ??

Hello Matt,

I merged your commit about that issue, many thanks !

  
http://github.com/jmettraux/ruote/commit/567baee90d50c81568727b1513f3c82e871e8376
  
http://github.com/jmettraux/ruote/commit/ca8c859cb0f194617ebc1ffed22d9b38291dcac8

> Issue 2:
> Although it looks like it should work, you can't instantiate an engine with
> only a storage. See attached unit test file. The first test works like a
> charm. The second test fails. It looks like the engine is not initializing
> the context correctly when given a storage. I tried to fix it by passing the
> storage and the engine, but the rabbit hole got deeper. I'm not sure what
> the relationship is between the engine and the context.

Nice catch and thanks a lot for the test, it's in.

  
http://github.com/jmettraux/ruote/commit/22d37d3fa8211f61da8c7b99b52a474342f35fb0


Thanks again and a happy new year,

-- 
John Mettraux   -   http://jmettraux.wordpress.com

-- 
you received this message because you are subscribed to the "ruote users" group.
to post : send email to [email protected]
to unsubscribe : send email to [email protected]
more options : http://groups.google.com/group/openwferu-users?hl=en

Reply via email to