On Oct 5, 8:40 am, John Mettraux <[email protected]> wrote: > On Tue, Oct 05, 2010 at 06:34:38AM +0000, Hartog C. de Mik wrote: > > On Tue, Oct 05, 2010 at 08:54:30AM +0900, John Mettraux wrote: > > > > I had a closer look at your pull request. > > > > http://github.com/kennethkalmer/ruote-amqp/pull/1 > > > > It's not necessary. Informations like "command" and "reply_queue" are > > > already passed in > > > > workitem['params']['participant_options'] > > > > Thanks anyway, kind regards, > > > My version of daemon-kit > > > % daemon-kit --version > > daemon-kit 0.1.8.1 (http://github.com/kennethkalmer/daemon-kit) > > > does not listen to 'command' and 'reply_queue' from the participant > > options, but seeks them in the first level of the workitem hash. > > Hello Hartog, > > I don't understand, what has daemon-kit to do with that ?
The AMQP participant is just a proxy to a queue - the real participant lives on the other end of that queue. A daemon-kit implementation of that real participant seems very likely. And the daemon-kit doesn't parse 'command' and 'reply_queue' from the 'participant_options'. I can understand if you don't want to integrate with the way daemon- kit handles this and if so I will be fixing daemon-kit rather then the RuoteAMQP::Participant. I still think that that setting a default reply_queue that matches the default listening queue of the RouteAMQP::Receiver is good practice (although, after having a peek into your fork a decision must be made some where wheter 'ruote_workitems' or 'ruote_launchitems' is to be default) > If you read carefully > > http://ruote.rubyforge.org/source.html > > you'll see that the latest version of ruote-amqp is at : > > http://github.com/jmettraux/ruote-amqp My bad; sorry about that. Grtz, Hartog. -- you received this message because you are subscribed to the "ruote users" group. to post : send email to [email protected] to unsubscribe : send email to [email protected] more options : http://groups.google.com/group/openwferu-users?hl=en
