On Thu, Feb 10, 2011 at 10:48:46AM -0600, Iuri Gagnidze wrote: > > Unfortunately I don¹t have a backtrace ‹ we patched it(in the calling > code, non ruote files) by manually skipping processes that have 0 > expressions. We were getting missing_method 'attribute' for nilclass when > we were trying to iterate through processes that collect their > definition_name. The error was raised ultimately for processes that had 0 > expressions in them (and maybe wfid=nil, not sure about this).
Hello Iuri, I think I know the root cause. https://github.com/jmettraux/ruote/blob/f496d53ba0962c3f3048b09b5015e19fe07cc928/lib/ruote/engine/process_status.rb#L161-164 https://github.com/jmettraux/ruote/blob/f496d53ba0962c3f3048b09b5015e19fe07cc928/lib/ruote/engine/process_status.rb#L72-91 Could be triggered by a process that has no root expression anymore (this covers your "no expressions anymore" case). I will come up with a proper test case and a proper fix. > Running > through ruote Engine#processes I found that wfid variable can be different > if passing options hash with some garbage in it (eg :test=>²test²). I > would expect to have the same list of processes returned by > Engine#processes if I don¹t pass options hash or if I pass options hash > with unusable keys. OK, that's a second issue, those garbage opts get passed to Storage#expression_wfids https://github.com/jmettraux/ruote/blob/2e75b2b75ca1caa5495e0756e0986fa34aafd46e/lib/ruote/engine.rb#L269 https://github.com/jmettraux/ruote/blob/2e75b2b75ca1caa5495e0756e0986fa34aafd46e/lib/ruote/storage/base.rb#L114-133 I guess the "if opts.size > 0" is hurting (as suggested by your patch). I will add a test case and integrate your patch. By the way, what storage implementation are you using ? Thanks for reporting those issues, stay tuned, -- John Mettraux - http://jmettraux.wordpress.com -- you received this message because you are subscribed to the "ruote users" group. to post : send email to [email protected] to unsubscribe : send email to [email protected] more options : http://groups.google.com/group/openwferu-users?hl=en
