Thanks John. On Feb 12, 2011 3:55 AM, "John Mettraux" <[email protected]> wrote: > > On Fri, Feb 11, 2011 at 11:52:26AM +0900, John Mettraux wrote: >> >> On Thu, Feb 10, 2011 at 10:48:46AM -0600, Iuri Gagnidze wrote: >> > >> > Unfortunately I don¹t have a backtrace ‹ we patched it(in the calling >> > code, non ruote files) by manually skipping processes that have 0 >> > expressions. We were getting missing_method 'attribute' for nilclass when >> > we were trying to iterate through processes that collect their >> > definition_name. The error was raised ultimately for processes that had 0 >> > expressions in them (and maybe wfid=nil, not sure about this). >> >> I will come up with a proper test case and a proper fix. > > Hello Iuri, > > this got fixed in > > https://github.com/jmettraux/ruote/commit/851a2daf9e87b7bbc91d29f5d7fdac5b5d744c30 > >> > Running >> > through ruote Engine#processes I found that wfid variable can be different >> > if passing options hash with some garbage in it (eg :test=>²test²). I >> > would expect to have the same list of processes returned by >> > Engine#processes if I don¹t pass options hash or if I pass options hash >> > with unusable keys. >> >> I will add a test case and integrate your patch. > > I integrated your patch as > > https://github.com/jmettraux/ruote/commit/6c1e9c5529a7cf343b58e5553f116b7a5379f457 > > #processes now looks like > > https://github.com/jmettraux/ruote/blob/9597c8997c89dcc83553d90bd721679b1d2f6a12/lib/ruote/engine.rb#L263-268 > > Your initial issue was caused by "leftovers", ie workitems, errors or schedules for which there are no more expressions. #processes is no simplified and should not return ProcessStatus instances when there are no expressions (as you pointed out). > > I've added a #leftovers method to Engine to retrieve such "leftovers" (and potentially delete them and/or investigate why they ended up being left over). > > https://github.com/jmettraux/ruote/commit/9597c8997c89dcc83553d90bd721679b1d2f6a12 > > > Many thanks, > > -- > John Mettraux - http://jmettraux.wordpress.com > > -- > you received this message because you are subscribed to the "ruote users" group. > to post : send email to [email protected] > to unsubscribe : send email to [email protected] > more options : http://groups.google.com/group/openwferu-users?hl=en
-- you received this message because you are subscribed to the "ruote users" group. to post : send email to [email protected] to unsubscribe : send email to [email protected] more options : http://groups.google.com/group/openwferu-users?hl=en
