(stability) Quite a chunk of code. Did you write it from scratch? How thoroughly is this tested by now? Does this work with kernel 2.4? Lot's of users are stuck to these kernels.
(packaging) I don't mean to be picky, but wouldn't it make sense to keep code that depends on specific package with that package? This could result in /lib/functions/mount.sh ... mount.ext2.sh ... mount.xfs.sh ... mount.swap.sh ... fsck.sh ... fsck.ext2.sh ... fsck.xfs.sh ... and so on This would make the initial space used smaller and it grows with the needed functionality. It will get rid of all the if/elif redundant code and hence easier to maintain. (usability) I like that you are putting infos to the logs. But there could be more. Especially when e.g. fsck'ing is enabled but the software missing. Or in every similar case, the user should see a statement to install the package or disable the request. (fix) As I will surely add a file based swapping, swap should be disabled before unmounting the file systems. So far for now, good work .. ede On 30.01.2010 02:13, Daniel Dickinson wrote: > The attached patch replaces the current /etc/hotplug.d/block/10-mount > and adds a shared shell script 'library' that, with this patch, is used > by hotplug automount and fstab, and will be used by the rootfs on > external storage package that I am working on as well. > > You can turn automount completely off. > You can set it to do only mounts from fstab > You can set it to do only 'anonymous' mounts (mounted under /mnt/device) > Ditto swap (if swap-utils is installed) > You can mix and match > You can control whether anonymous mounts get their filesystem checked > You can control fstab filesystem checks on a per mount point basis > (fsck depends on the appropriate package being installed) > You can mount via uuid or label if blkid is installed > > I will document on the wiki if it gets accepted. > > Regards, > > Daniel > > > > > _______________________________________________ > openwrt-devel mailing list > [email protected] > https://lists.openwrt.org/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
