On Sat, 2010-01-30 at 12:47 +0100, [email protected] wrote: > (stability) > Quite a chunk of code. Did you write it from scratch?
Yes > How thoroughly is this tested by now? Well I've tested a number of scenarios / code paths, but there is probably something I've missed. > Does this work with kernel 2.4? Lot's of users are stuck to these kernels. No reason it shouldn't. > (packaging) > I don't mean to be picky, but wouldn't it make sense to keep code that > depends on specific package with that package? This could result in > > /lib/functions/mount.sh > ... mount.ext2.sh > ... mount.xfs.sh > ... mount.swap.sh > ... fsck.sh > ... fsck.ext2.sh > ... fsck.xfs.sh > ... and so on > > This would make the initial space used smaller and it grows with the > needed functionality. It will get rid of all the if/elif redundant code > and hence easier to maintain. I think the main place it's make a difference is the fsck, and I think that modularizing it does make sense. > (usability) > I like that you are putting infos to the logs. But there could be more. > Especially when e.g. fsck'ing is enabled but the software missing. Or in > every similar case, the user should see a statement to install the > package or disable the request. Interesting idea. If I don't work on this, please feel free to do so. > (fix) > As I will surely add a file based swapping, swap should be disabled > before unmounting the file systems. To be honest I'm not sure how useful the unmount in hotplug really is anyway...usually if it's called it mean the device has already been removed, I think. -- And that's my crabbing done for the day. Got it out of the way early, now I have the rest of the afternoon to sniff fragrant tea-roses or strangle cute bunnies or something. -- Michael Devore GnuPG Key Fingerprint 86 F5 81 A5 D4 2E 1F 1C http://gnupg.org The C Shore (Daniel Dickinson's Website) http://cshore.is-a-geek.com
signature.asc
Description: This is a digitally signed message part
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
