Hi Gabor, > Sorry, i did not have time earlier.
No harm done (except for few devices ;-). >> Perhaps an easier workaround would be to unconditionally enable header >> mode for the ar8216, the special netif_receive_skb() handling wouldn't >> be needed anymore. > > Do you mean the special handling in the ag71xx driver itself? > >> Although this would disable the invalid VID fixup. >> >>>> I also just saw that all 3 devices having 'has_ar8216' do not have a >>>> phy_mask >>>> defined, so the driver never has a chance to attach anyway. >>> Incorrect, see above. >> >> You are right, they still have for the WAN port where it attaches itself. > > Yes, i have missed this fact earlier. > >> Looking at the TEW-632BRP, I assume its bootloader doesn't enable the >> header mode? It doesn't have the 'has_ar8216' flag set. > I just looked at the code again, and I think I know now how to fix the problem for the devices where the AR8216 is usable through MDIO. The problem is that the ag71xx driver should call the phy's netif_receive_skb, but it doesn't. I'll send a patch shortly. After that all devices where the AR8216 driver attaches successfully do not need their has_ar8216 flag anymore, as then the phy driver itself can handle it. The problems with the ar8216 driver itself will be adressed in a separate patch. Regards, Jonas Gorski _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
