Yea, I've been testing this builds on two machines 8-core Ubuntu 10.04 box 12-core Mac OS X 10.6.4 box
I start by timing the package compilation using -j1 and no PKG_BUILD_PARALLEL. Then I enable PKG_BUILD_PARALLEL and try compilation on the package with parallel enabled. Finally, after I verified the individual package build, I take the tree, distclean, on both Linux and Darwin, and build the whole tree. I've actually built the tree in a couple of iterations varying the PKG_JOBS parameter and the -j passed to the make call at the top-most level (performing a clean between each run) to see which is most optimal for my setup and configuration. I've successfully compiled using all 26 changes on both machines from a distclean'd tree. I'll re-submit all 26 changes with the changes suggested by Felix in one email. Probably in 20 min or so. Joe On Sep 6, 2010, at 3:31 PM, Michael Büsch wrote: > On Mon, 2010-09-06 at 15:24 -0600, Joseph Roback wrote: >> Oh, sorry. Should I re-submit? Additionally, I submitted 25 other patches >> for enabling parallel builds in an earlier mailing, should I re-submit them >> as well? > > Oh, dang, I missed them and already deleted them from my inbox. > I am gonna review and commit them, if you re-submit them with the change > suggested by Felix. > (I guess you already compiletested them. It's also useful to do one or > two dircleans or similar and rebuild the whole tree to make sure they > behave well in parallel build). > > -- > Greetings Michael. > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
