A few comments:

On 13 May 2011 22:40, Jonathan McCrohan <[email protected]> wrote:
> Signed-off-by: Jonathan McCrohan <[email protected]>
>
> Index: feeds
> ===================================================================
> --- feeds       (revision 26887)
> +++ feeds       (working copy)

Where is this feeds located? it should have a full path
(a/scripts/feeds or something like that).

> @@ -117,6 +117,10 @@
>                'init_branch'   => "git clone --depth 1 --branch '%s' '%s' 
> '%s'",
>                'update'        => "git pull",
>                'controldir'    => ".git"},
> +       'src-gitsvn' => {
> +                'init'          => "git svn clone '%s' '%s'",

You might want to use '-r HEAD' if no revision is provided, else git
svn pull the whole revision history from the svn, and that's not very
efficient (and usually quite slow).

> +                'update'        => "git svn rebase",
> +                'controldir'    => ".git"},
>        'src-bzr' => {
>                'init'          => "bzr checkout --lightweight '%s' '%s'",
>                'update'        => "bzr update",


Also note this part of the code
<https://dev.openwrt.org/browser/trunk/scripts/feeds#L284>:

 my %install_method = (
        'src-svn' => \&install_generic,
        'src-cpy' => \&install_generic,
        'src-link' => \&install_generic,
        'src-git' => \&install_generic,
        'src-bzr' => \&install_generic,
        'src-hg' => \&install_generic,
        'src-darcs' => \&install_generic,
);

You probably need to add yours there, too.


Jonas
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to