Hi Jonas,
On 15/05/11 15:11, Jonas Gorski wrote:
> Where is this feeds located? it should have a full path
> (a/scripts/feeds or something like that).
Whoops. I didn't notice I was in the wrong directory when running the diff.
>> @@ -117,6 +117,10 @@
>> 'init_branch' => "git clone --depth 1 --branch '%s' '%s'
>> '%s'",
>> 'update' => "git pull",
>> 'controldir' => ".git"},
>> + 'src-gitsvn' => {
>> + 'init' => "git svn clone '%s' '%s'",
>
> You might want to use '-r HEAD' if no revision is provided, else git
> svn pull the whole revision history from the svn, and that's not very
> efficient (and usually quite slow).
Good idea. Added to updated patch.
> Also note this part of the code
> <https://dev.openwrt.org/browser/trunk/scripts/feeds#L284>:
>
> my %install_method = (
> 'src-svn' => \&install_generic,
> 'src-cpy' => \&install_generic,
> 'src-link' => \&install_generic,
> 'src-git' => \&install_generic,
> 'src-bzr' => \&install_generic,
> 'src-hg' => \&install_generic,
> 'src-darcs' => \&install_generic,
> );
>
> You probably need to add yours there, too.
I hadn't noticed that either. Added to updated patch.
Jonathan
Signed-off-by: Jonathan McCrohan <[email protected]>
Index: scripts/feeds
===================================================================
--- scripts/feeds (revision 26941)
+++ scripts/feeds (working copy)
@@ -117,6 +117,10 @@
'init_branch' => "git clone --depth 1 --branch '%s' '%s'
'%s'",
'update' => "git pull",
'controldir' => ".git"},
+ 'src-gitsvn' => {
+ 'init' => "git svn clone -r HEAD '%s' '%s'",
+ 'update' => "git svn rebase",
+ 'controldir' => ".git"},
'src-bzr' => {
'init' => "bzr checkout --lightweight '%s' '%s'",
'update' => "bzr update",
@@ -286,6 +290,7 @@
'src-cpy' => \&install_generic,
'src-link' => \&install_generic,
'src-git' => \&install_generic,
+ 'src-gitsvn' => \&install_generic,
'src-bzr' => \&install_generic,
'src-hg' => \&install_generic,
'src-darcs' => \&install_generic,
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
